Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[fuchsia] Disable retained vulkan surfaces until we figure out why th… - #16316

Closed
mikejurka wants to merge 1 commit into
flutter-team-archive:masterfrom
mikejurka:no_retained_surfaces
Closed

[fuchsia] Disable retained vulkan surfaces until we figure out why th…#16316
mikejurka wants to merge 1 commit into
flutter-team-archive:masterfrom
mikejurka:no_retained_surfaces

Conversation

@mikejurka

Copy link
Copy Markdown
Contributor

…ey're being recycled prematurely.

@liyuqian liyuqian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liyuqian

liyuqian commented Feb 1, 2020

Copy link
Copy Markdown
Contributor

You may need to rebase the change to the tip-of-tree engine in order to pass the test.

@mikejurka

Copy link
Copy Markdown
Contributor Author

OK. I'm also not sure about the performance implications of this. Probably best to talk next week.

@mikejurka
mikejurka requested a review from schwa423 February 3, 2020 22:15
@iskakaushik

Copy link
Copy Markdown
Contributor

closing and reopening as #16548

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

5 participants